Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): Current campaign - Discovery Page #1614

Merged
merged 14 commits into from
Jan 23, 2025
Merged

feat(cat-voices): Current campaign - Discovery Page #1614

merged 14 commits into from
Jan 23, 2025

Conversation

LynxLynxx
Copy link
Contributor

Description

Creating current campaign view for Discovery Page

Related Issue(s)

Closes #1548

Description of Changes

Screenshots

Nagranie.z.ekranu.2025-01-22.o.16.14.14.mov

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added review me PR is ready for review ux/ui UX/UI related issues F14 labels Jan 22, 2025
@LynxLynxx LynxLynxx self-assigned this Jan 22, 2025
@LynxLynxx LynxLynxx changed the base branch from main to feat/1551-discoveryLayout January 22, 2025 15:18
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 39/39}$ | ${\color{red}Fail: 0/39}$ |

@LynxLynxx LynxLynxx mentioned this pull request Jan 22, 2025
Merged
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 410/410}$ | ${\color{red}Fail: 0/410}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 410/410}$ | ${\color{red}Fail: 0/410}$ |

damian-molinski
damian-molinski reviewed Jan 23, 2025
View reviewed changes
catalyst_voices/apps/voices/lib/common/ext/build_context_ext.dart Outdated Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/discovery/current_campaign.dart Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/discovery/current_campaign.dart Outdated Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/discovery/current_campaign.dart Outdated Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/discovery/current_campaign.dart Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/discovery/current_campaign.dart Outdated Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/discovery/current_campaign.dart Show resolved Hide resolved
...s/packages/internal/catalyst_voices_brands/lib/src/theme_extensions/voices_color_scheme.dart Show resolved Hide resolved
catalyst_voices/apps/voices/lib/common/formatters/date_formatter.dart Show resolved Hide resolved
catalyst_voices/apps/voices/lib/pages/discovery/discovery_page.dart Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

damian-molinski
damian-molinski approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LynxLynxx LynxLynxx merged commit 2fcf3c1 into feat/1551-discoveryLayout Jan 23, 2025
42 checks passed
@LynxLynxx LynxLynxx deleted the feat/1548-currentCampaign branch January 23, 2025 14:55
LynxLynxx added a commit that referenced this pull request Jan 24, 2025
@LynxLynxx
feat(cat-voices): Discovery page layout (#1577)
88b52a6 
* feat: hero-section header

* feat: creating discovery page layout for f14

* fix: remove unused keys for widget

* feat: adding to proposalViewmodel isfavorite param

* chore: removing guard on proposals page

* feat(cat-voices):  Current campaign - Discovery Page (#1614)

* feat: making section hero widget more generic

* chore: remove unused file

* fix: typo

* feat: creating ui layout for current campaign

* feat: adding timeline card ui layout

* feat: adding idea journey

* fix: styling

* fix: formatting

* chore: making changes acording to reviews

* fix: styling

* chore: delete unused todos

* feat(cat-voices): Hero section - discovery page (#1574)

* feat: making section hero widget more generic

* chore: remove unused file

* fix: typo

* feat: adding didupdatewidget

* chore: moving init func to other widget

* fix: styling

* feat: adding _effectiveController

* fix: mounted check

* fix: formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@dtscalac dtscalac Awaiting requested review from dtscalac

Assignees

@LynxLynxx LynxLynxx

Labels
F14 review me PR is ready for review ux/ui UX/UI related issues
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Current Campaign Info
3 participants
@LynxLynxx @damian-molinski @dtscalac